feat: improved-image-Type-detection in build-rss.js

lakshaydewan commented 3 weeks ago

Improved the image type detection logic in the build-rss.js file by adding a new function to get the image's MIME type from its url rather than going over each if-checks improving the maintainability and readability of the code

Summary by CodeRabbit

New Features
- Introduced a new function to dynamically determine MIME types based on file extensions from URLs, enhancing file handling.
Bug Fixes
- Simplified the logic for constructing the enclosure object in the RSS feed, improving efficiency and maintainability.

netlify[bot] commented 3 weeks ago

Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name	Link
Latest commit	b8392778bb6f244a473d7107cf0c19c3efa096da
Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/67250e7c2add3a00083200f4

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.68%. Comparing base (551c47a) to head (b839277). Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
scripts/build-rss.js	25.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3359 +/- ## ========================================== + Coverage 49.14% 49.68% +0.53% ========================================== Files 21 21 Lines 647 642 -5 ========================================== + Hits 318 319 +1 + Misses 329 323 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes introduce a new constant MIME_TYPES in scripts/build-rss.js, which maps file extensions to their corresponding MIME types. A new function, getMimeType(url), is added to determine the MIME type based on the file extension from a provided URL. The rssFeed function is updated to use getMimeType for setting the MIME type of the enclosure object, simplifying the code by removing manual checks for specific file types.

Changes

File	Change Summary
scripts/build-rss.js	Added constant `MIME_TYPES` for MIME type mapping and function `getMimeType(url)` for MIME type determination. Updated `rssFeed` function to utilize `getMimeType` for setting the enclosure's MIME type.

Possibly related issues

asyncapi/website#3357: The changes improve image type detection in build-rss.js, addressing the need to enhance maintainability and handle more image formats as discussed in the issue.

Poem

🐰 In the land of code, where rabbits play,
New MIME types hop in, brightening the day.
With getMimeType, we simplify our quest,
Enclosures now gleam, they’re truly the best!
So here’s to the changes, let’s cheer and rejoice,
For clearer, cleaner code, let’s raise our voice! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

asyncapi / website