asyncapi / website

AsyncAPI specification website
https://www.asyncapi.com
Apache License 2.0
510 stars 654 forks source link

[BUG] algolia search icon not visible on website navbar #3371

Open anshgoyalevil opened 1 week ago

anshgoyalevil commented 1 week ago

Describe the bug.

There used to be an Algolia Search Icon besides the Language Picker element on Navbar. It is no longer visible, though we can click it as it is present over there but is very small in size.

Expected behavior

image

In wireframe:

image

Screenshots

image

In wireframe:

image

(That circle besides the Language Picker is where the search icon used to be)

How to Reproduce

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it

amanbhoria commented 1 week ago

Hi @anshgoyalevil , I've looked into this issue and seems like IconLoupe component i.e Search icon is not rendered correctly as a children prop in AlgoliaSearch file.

image

image

As soon as i do setChildren(children) the search bar appears on the homepage. If we've to fix this issue, we can do it that way. But yes, we can't do this as we can't use the actionKey then.

These are my findings, thank you!

maverickf0 commented 1 week ago

@amanbhoria can't we just do this instead image

it solves the issue

amanbhoria commented 1 week ago

@maverickf0 this seems to be working fine but I'm wondering how this issue occurred on the first place. I mean how this got merged in the master branch.