fix: #3371 visibility issue with algolia search icon in navbar

jyotishpro commented 1 week ago

Description fix: #3371

Before:

Now:

Related issue(s) -Fixes #3371

Summary by CodeRabbit

New Features
- Enhanced language selection process with unique language options retrieval.
- Improved language change handling with local storage support and refined URL construction.
- Updated mobile navigation menu with a new search button design.
Style
- Updated styling for the SearchButton component, including a new background image from an SVG icon and adjusted class names for consistency.
- Increased clickable area for the SearchButton in the mobile navigation menu.

These changes enhance user experience by providing better language options and a visually appealing interface.

coderabbitai[bot] commented 1 week ago

Walkthrough

The NavBar component in NavBar.tsx has been enhanced with new functionality for language selection and improved styling. A new method, getUniqueLangs, retrieves unique language options based on the current path, while the changeLanguage function has been updated for better handling of language changes and URL generation. Additionally, styling adjustments have been made to the SearchButton component, including a new background image from an SVG icon. These modifications collectively improve user interaction and visual presentation in the navigation bar.

Changes

File Path	Change Summary
components/navigation/NavBar.tsx	- Added method: `getUniqueLangs()` - Updated method: `changeLanguage(locale: string, langPicker: boolean)` - Added variable: `const loupeSvg` for styling adjustments to `SearchButton`
components/navigation/MobileNavMenu.tsx	- Added variable: `const loupeSvg` for SVG background in `SearchButton` - Increased padding for `SearchButton` from `p-2` to `p-4`

Assessment against linked issues

Objective	Addressed	Explanation
Algolia search icon visibility on navbar (#3371)	✅

Possibly related PRs

#3346: This PR adds a cursor pointer to the language selector, which is directly related to the changes in the changeLanguage function in the main PR, as both involve enhancing the user interface for language selection.

Suggested labels

ready-to-merge

Suggested reviewers

derberg
akshatnema
magicmatatjahu
Mayaleeeee
asyncapi-bot-eve
sambhavgupta0705
anshgoyalevil

🐰 In the navbar, a change so bright,
Languages dance, a delightful sight.
With a search icon now bold and clear,
Hop along, all is well, have no fear!
SVG shines, and options abound,
In this lovely space, joy can be found! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

netlify[bot] commented 1 week ago

Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name	Link
Latest commit	117e2a22afea50de1c4d456573681aa49bcd4b59
Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/6738416103cc140008a169eb

jyotishpro commented 1 week ago

Fixes #3371

asyncapi-bot commented 1 week ago

⚡️ Lighthouse report for the changes in this PR:	Category	Score
🔴 Performance	39
🟢 Accessibility	98
🟢 Best practices	92
🟢 SEO	100
🔴 PWA	33

Lighthouse ran on https://deploy-preview-3400--asyncapi-website.netlify.app/

asyncapi / website