Closed vishvamsinh28 closed 3 days ago
The changes in this pull request involve enhancements to the test setups for two test files: build-newsroom-videos.test.js
and build-tools.test.js
. The modifications include adding file creation steps using outputFileSync
from the fs-extra
module to ensure that specific JSON files are present before the tests are executed. This adjustment aims to prevent errors related to missing files and maintains the integrity of the test cases, which continue to cover various error scenarios.
File Path | Change Summary |
---|---|
tests/build-newsroom-videos.test.js | Added outputFileSync import and created an empty JSON file at testFilePath in beforeAll . |
tests/build-tools.test.js | Added file output operations to initialize automatedToolsPath , toolsPath , and tagsPath as empty JSON files in beforeAll . |
build-tools.js
and its tests to use fs-extra
, similar to the main PR's introduction of outputFileSync
from fs-extra
in the test setup for build-newsroom-videos.test.js
. Both PRs enhance file handling capabilities and ensure necessary files are created before tests run.ready-to-merge
, autoupdate
🐇 In the land of tests, we now create,
JSON files to ensure no fate of late.
Withfs-extra
by our side,
Errors we’ll swiftly abide.
Each test now runs with glee,
Thanks to files, as they should be! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Name | Link |
---|---|
Latest commit | b0c7afc2dd8a2d808d0f420174ae900cad979ebe |
Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/6740c93a064ed9000863d69d |
Deploy Preview | https://deploy-preview-3422--asyncapi-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.77%. Comparing base (
4c5f284
) to head (b0c7afc
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
⚡️ Lighthouse report for the changes in this PR: | Category | Score |
---|---|---|
🔴 Performance | 33 | |
🟢 Accessibility | 98 | |
🟢 Best practices | 92 | |
🟢 SEO | 100 | |
🔴 PWA | 33 |
Lighthouse ran on https://deploy-preview-3422--asyncapi-website.netlify.app/
/rtm
This PR fixes the file not found issue for tests of build-tools and newsroom video script
Summary by CodeRabbit