asyncer-io / r2dbc-mysql

Reactive Relational Database Connectivity for MySQL. The official successor to mirromutth/r2dbc-mysql(dev.miku:r2dbc-mysql).
https://r2dbc.io
Apache License 2.0
206 stars 21 forks source link

Handling int<lenenc> fields from MySQL OK_Packets #78

Closed svats0001 closed 1 year ago

svats0001 commented 1 year ago

Hi @jchrys ,

39

Motivation: Incoming values from MySQL OK_Packets that exceed 2^63-1 will incorrectly be represented as negative numbers in the string representation of the message object.

Modifications: I changed the toString method in the OkMessage class so that the unsigned long fields are converted into unsigned strings. I'm not aware of any other classes that deal with mySQL length encoded integer fields.

Results: When a value greater than 2^63-1 is received from a MySQL OK_Packet, that value is preserved in the string representation of the OkMessage object.

jchrys commented 1 year ago

Hello, @svats0001. This looks great to me. Thanks very much. if you have time could you make your commit message follow below format like other commit messages?

title

motivation:

modifications:

results:
jchrys commented 1 year ago

Unfortunately, we're currently experiencing issues with our CI system when running tests on forked pull requests. Once this issue is resolved, I would be happy to merge your changes into our codebase.

svats0001 commented 1 year ago

No worries. I've updated my original commit message.

jchrys commented 1 year ago

Thanks a lot!