asyncer-io / r2dbc-mysql

Reactive Relational Database Connectivity for MySQL. The official successor to mirromutth/r2dbc-mysql(dev.miku:r2dbc-mysql).
https://r2dbc.io
Apache License 2.0
206 stars 21 forks source link

Simplify build jobs using a matrix #86

Closed saurabhyadav1985 closed 1 year ago

saurabhyadav1985 commented 1 year ago

Motivation: Reduce duplication in the GitHub Actions workflow unit-tests https://github.com/asyncer-io/r2dbc-mysql/issues/83

Modification: Refactored three jobs into one, now will build using strategy.matrix.version

Result: Jobs should build for Java 8, 11 and 17 version.

saurabhyadav1985 commented 1 year ago

Hey can you please delete my fork so I can fork again and raise PR as I am unable to squash into one commit

jchrys commented 1 year ago

You don't need to delete your fork to achieve this; you can do it by yourself.

Try the following steps:

$ git checkout {yourbranch} $ git rebase -i trunk Squash all commits except the top one. Create a commit message. $ git push --force

jchrys commented 1 year ago

I squash merged to make it a single commit. Thanks a lot!