search

asyncer-io / r2dbc-mysql

Reactive Relational Database Connectivity for MySQL. The official successor to mirromutth/r2dbc-mysql(dev.miku:r2dbc-mysql).
https://r2dbc.io
Apache License 2.0
206 stars 21 forks source link

Added Wrapped interface #88

Closed svats0001 closed 1 year ago

svats0001 commented 1 year ago

Hi @jchrys,

65

EDIT: The Wrapped interface already exists in the io.r2dbc.spi package, I think by support you meant the implementation?

I created the Wrapped optional interface. I'm unsure if I need to implement this anywhere or if it's entirely up to the end user.

Motivation: To add support for the Wrapped optional interface in the R2DBC specification so that we can access an instance of a resource that has been wrapped or for implementers to expose wrapped resources.

Modification: Added the Wrapped interface into the io.asyncer.r2dbc.mysql package.

Result: We can now access an instance of a resource that has been wrapped or expose wrapped resources.

jchrys commented 1 year ago

Hello, @svats0001. Yes, You're correct. we need to implement it. I think we can refer mysql-connector-j's implementation. (https://javadoc.io/doc/com.mysql/mysql-connector-j/latest/index.html) However, as it's an optional feature and we have not received any requests from users for this functionality, we do not need to prioritize it immediately. That being said, if you are interested and have the bandwidth to work on this feature, we would certainly appreciate your efforts.

Thanks!

svats0001 commented 1 year ago

I'll have a look at implementing it when possible. I'll close this PR now.