Closed icanhasjonas closed 7 years ago
error CS0433: The type 'NotNullAttribute' exists in both 'JetBrains.Annotations.Dotnet, Version=10.1.5.0, Culture=neutral, PublicKeyToken=1010a0d8d6380325'
and 'Wire, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'
Thanks for reporting, I have moved the annotations to a different namespace, that should be sufficient, right? there is requirement for the Jetbrains tool to have the original namespace AFAIK.
Yes, but you can also change the visibility to internal
.
Here's how:
Code Inspection / Code Annotations
page you'll find: Annotations source code: Make annotations [x] internal [ ] conditional
If you use the JetBrains.Annotations
NuGet package, the attributes are marked as [Conditional("JETBRAINS_ANNOTATIONS")]
so aren't included in the compiled output, unless you include that symbol at compile time.
This means the annotations aren't available to consumers of the package. However you can also generate an XML version of the annotations from the ReSharper "internal" menu, if you run devenv /ReShaper.Internal
, and include that XML file in the package.
Any plans to release a new package to NuGet with those annotations removed or changed to internal? They are blocking me to even compile and I don't really know a way to exclude them without going back to an older Wire.
Fixed but not published, will publish asap after some more issues are done.
I suggest one of the following:
Wire
import theJetBrains.Annotations
inproject.json
internal
so they're not exposed to consumers