search

asynkron / protoactor-dotnet

Proto Actor - Ultra fast distributed actors for Go, C# and Java/Kotlin
http://proto.actor
Apache License 2.0
1.73k stars 288 forks source link

Outgoing middleware design broken #101

Closed rogeralsing closed 7 years ago

rogeralsing commented 7 years ago

Currently the outgoing middleware has all the parts it needs internally. but, the Process.SendUserMessage has the signature: (PID pid, object message, PID sender) which does not allow us for sending outgoing headers. And if we try to send a MessageEnvelope, things get double wrapped if there is a sender as the LocalProcess checks for sender and wraps the current message in another MessageEnvelope.

TLDR;

We should change the signature of SendUserMessage to just (PID pid, object message) and do the envelope wrapping already in Request

cpx86 commented 7 years ago

Do we have the same issue in Go? I.e. is this a porting issue or was the solution broken from the start?

rogeralsing commented 7 years ago

Yes, same issue there We really should have a Proto.Actor meta/design issue tracker

cpx86 commented 7 years ago

Yeah maybe we should have a new "protoactor" repo for cross-cutting concerns. That could also be used for core documentation that's not specific to any language.

cpx86 commented 7 years ago

Or we can just repurpose the "gam-web" repo - rename it to "protoactor" and use it for both the website and for general/meta issue tracking.

rogeralsing commented 7 years ago

relates to #127

rogeralsing commented 7 years ago

This has been fixed