asynkron / protoactor-dotnet

Proto Actor - Ultra fast distributed actors for Go, C# and Java/Kotlin
http://proto.actor
Apache License 2.0
1.73k stars 288 forks source link

Change container metadata to use CONTAINER_APP_REPLICA_NAME #2099

Closed marioleed closed 9 months ago

marioleed commented 9 months ago

Replace environment variable HOSTNAME with CONTAINER_APP_REPLICA_NAME.

Description

In new ACA Environment with workload profiles, using the Consumption profile, HOSTNAME does not appear to exist as an environment variable anymore - thus the application cannot start. However, the env variable CONTAINER_APP_REPLICA_NAME exists in both classic ACA Environment (Consumption) and in new workload profiles (Dedicated + Consumption). So this change should be backwards compatible as well.

Also, it makes more sense in this context and uses the same standard as the other Container App metadata env variables that are fetched.

Purpose

This pull request is a:

Checklist

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.