asynkron / protoactor-dotnet

Proto Actor - Ultra fast distributed actors for Go, C# and Java/Kotlin
http://proto.actor
Apache License 2.0
1.73k stars 288 forks source link

Get rid of net452 build target #485

Closed alexeyzimarev closed 4 years ago

alexeyzimarev commented 4 years ago

Today, the .NET Framework 4.5.2 build target creates too many impediments for updating dependencies. Apparently, many libs like SQLite and tons of Microsoft own libs are .NET Standard 2.0 only.

I could suggest stopping to support .NET Framework 4.5.2 and to support .NET Standard 2.0 only.

cpx86 commented 4 years ago

I'm all for this - supporting anything below 4.6.1 isn't necessary. @alexeyzimarev up for submitting a PR? :)

alexeyzimarev commented 4 years ago

Yeah, I started by simply removing a couple of remaining async voids in the scheduler but ended up doing more, have it almost ready. Will submit soon.

alexeyzimarev commented 4 years ago

@cpx86 in my PR I removed 4.6.1 target as well, leaving only .NET Standard. Is it a good move? I would say yes, it allowed me to use the latest version of Sqlite client library without an ugly #if. If we need to ensure that everything works with 4.6.1, I can change test projects to have two targets.