asynkron / protoactor-kotlin

Ultra-fast distributed cross-platform actor framework
http://proto.actor
Apache License 2.0
221 stars 25 forks source link

Package proto in to the generated jar files #13

Closed orjan closed 7 years ago

orjan commented 7 years ago

This makes it easier for clients to use the proto files for proto.actor by using tooling like: https://github.com/google/protobuf-gradle-plugin since it's then possible to import the protos like this, without the need of placing the source in the repository.

import "actor/proto/ActorProtos.proto";

Possible regressions:

codecov-io commented 7 years ago

Codecov Report

Merging #13 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage     23.43%   23.43%           
+ Complexity      139      136    -3     
=========================================
  Files            51       51           
  Lines          1762     1762           
  Branches        296      296           
=========================================
  Hits            413      413           
  Misses         1263     1263           
  Partials         86       86

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca94fb9...9a016e2. Read the comment docs.

rogeralsing commented 7 years ago

Awesome!