aszc-dev / ComfyUI-CoreMLSuite

A set of custom nodes for ComfyUI that allow you to use Core ML models in your ComfyUI workflows.
GNU General Public License v3.0
120 stars 12 forks source link

Convertor keeps both files around? #16

Open cchance27 opened 10 months ago

cchance27 commented 10 months ago

I noticed the convertor is keeping the mlpackage and models around after conversion, shouldn't the convertor drop the prelude file to save space (maybe an option in the node to keep the uncompiled version, as with each size needing a model, having 2x the files adds up quick.

Technically we end up with 3x models, the modelc the mlpackage and the safe tensor, would be nice to make keeping that middle one optional, and by default to just remove it after compilation.

aszc-dev commented 10 months ago

I was thinking the same thing. Indeed, I don't see any purpose for mlpackage file in our use-case atm. For now, I think it's safe to delete that file. I don't want to bloat the interface with additional option (it seems a bit crowded as it is). I will change that in some future update.

cchance27 commented 10 months ago

ya definitly feels like cleaning up the intermediate is safe

x4080 commented 10 months ago

Hi, i just doing the conversion from realistic vision with target size 512x768,original,cpu and gpu, the result is only .mlpackage

but maybe because of error :

xcrun: error: unable to find utility "coremlcompiler", not a developer tool or in PATH
ERROR:root:!!! Exception during processing !!!

is something not installed in my mac ?

Thanks

x4080 commented 10 months ago

Ok after I investigate further the command 'xcrun coremlcompiler compile' that makes that errors. How to install "coremlcompiler" ?

cchance27 commented 10 months ago

did you have xcode installed when you installed the plugin?

x4080 commented 10 months ago

@cchance27 Yes I did, so I was surprised why its not working. Hope it can help someone

aszc-dev commented 10 months ago

@x4080 I don't know if you're still facing this issue, but if you are, there's an easy solution described in this article (It's in the last paragraph of Model Conversion section). Perhaps this could help?

x4080 commented 10 months ago

@aszc-dev already solved it thanks, it was xcode problem