search

aszepieniec / stark-anatomy

Tutorial for STARKs with supporting code in python
Apache License 2.0
181 stars 49 forks source link

Incorrect size of signature? #30

Open a00012025 opened 3 months ago

a00012025 commented 3 months ago

Hi, I noticed that in the code/test_rpsss.py it has following line

print("size of signature:", len(sig), "bytes, or ", len(sig) / (2**13), "kB")

Which outputs

size of signature: 1309136 bytes, or  159.806640625 kB

Should it be divided by 2**10 because sig is an array of bytes? If so, the signature sizes in rescue-prime.md and faster.md would need to be updated.

Besides, thanks for the great tutorial!

aszepieniec commented 3 months ago

My guess is that at some point I thought I was dealing with bits, in which case the conversion factor is $2^{13}$.