aszepieniec / stark-anatomy

Tutorial for STARKs with supporting code in python
Apache License 2.0
181 stars 49 forks source link

omicron variables are not assigned at all? #6

Closed KillariDev closed 2 years ago

KillariDev commented 2 years ago

Hey I am confused about these lines in stark.py in prove() function

# symbolically evaluate transition constraints
point = [Polynomial([self.field.zero(), self.field.one()])] + trace_polynomials + [tp.scale(self.omicron) for tp in trace_polynomials]
transition_polynomials = [a.evaluate_symbolic(point) for a in transition_constraints]

Isn't the point bigger array than transition_constraints have variables? And thus these omicron variables are not being assigned at all?

aszepieniec commented 2 years ago

The multivariate polynomials in transition_constraints should have 2w+1 variables, and that should also be the number of elements in point.

KillariDev commented 2 years ago

ah, you are right! Thank you.