search

at-gmbh / personio-py

a lightweight Personio API client
https://at-gmbh.github.io/personio-py
Apache License 2.0
26 stars 17 forks source link

add support for Projects; #30

Closed pietzschke closed 1 year ago

pietzschke commented 2 years ago

This PR adds support to CRUD Projects in the Personio API.

codecov-commenter commented 2 years ago

Codecov Report

Base: 86.71% // Head: 84.43% // Decreases project coverage by -2.27% :warning:

Coverage data is based on head (ff197e2) compared to base (3cd11f6). Patch coverage: 47.05% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #30 +/- ## ========================================== - Coverage 86.71% 84.43% -2.28% ========================================== Files 7 7 Lines 843 893 +50 ========================================== + Hits 731 754 +23 - Misses 112 139 +27 ``` | [Impacted Files](https://codecov.io/gh/at-gmbh/personio-py/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/personio\_py/\_\_init\_\_.py](https://codecov.io/gh/at-gmbh/personio-py/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3BlcnNvbmlvX3B5L19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | | | [src/personio\_py/client.py](https://codecov.io/gh/at-gmbh/personio-py/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3BlcnNvbmlvX3B5L2NsaWVudC5weQ==) | `71.56% <18.51%> (-7.90%)` | :arrow_down: | | [src/personio\_py/models.py](https://codecov.io/gh/at-gmbh/personio-py/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3BlcnNvbmlvX3B5L21vZGVscy5weQ==) | `89.30% <79.16%> (-0.58%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pietzschke commented 2 years ago

The PR is missing tests with mocking the API, would be great to know where to add them best or what the intended structure should be. Thanks!