Closed syphar closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b5ead78
) 87.31% compared to head (51915ea
) 87.32%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@klamann we found that this feature would have helped us writing cleaner code.
In our case we wanted retries for HTTP requests, and with the option to hand in a custom session this would have worked more easily.
Another usecase I can imagine for this would be proxies.
If the general feature is fine with you, I'll do tests & changelog.
I like the idea, and the change seems to be simple enough. I'm willing to merge this if you add a test case and changelog entry.
@klamann I updated the changelog, and added a short test with a custom session.
sorry for the deplay; merging!
Checklist for your PR
Hints
bugfix/
,feature/
, orrelease/
and then a short title for your PR in kebab-case (lowercase words separated with dashes), e.g.feature/my-awesome-feature
.