search

at-import / Singularity

Grids without limits
MIT License
1.5k stars 109 forks source link

duped styles from shared and per-column #69

Closed scottkellum closed 11 years ago

scottkellum commented 12 years ago

Here: https://gist.github.com/4051541

these lines should not be written on .a1-1:

  overflow: hidden;
  *zoom: 1;

from: https://github.com/scottkellum/Singularity/blob/master/example/sass/oocss-variable-padding.scss#L15

I tried removing this: https://github.com/scottkellum/Singularity/blob/master/example/sass/oocss-variable-padding.scss#L15

and all instances for that matter, but for some reason it kept compiling with *zoom: 1 there. Driving me nuts.

micahgodbolt commented 12 years ago

Is zoom 1 part of a clear fix? On Nov 10, 2012 8:30 AM, "Scott Kellum" notifications@github.com wrote:

Here: https://gist.github.com/4051541

these lines should not be written on .a1-1:

overflow: hidden; *zoom: 1;

from: https://github.com/scottkellum/Singularity/blob/master/example/sass/oocss-variable-padding.scss#L15

I tried removing this: https://github.com/scottkellum/Singularity/blob/master/example/sass/oocss-variable-padding.scss#L15

and all instances for that matter, but for some reason it kept compiling with *zoom: 1 there. Driving me nuts.

— Reply to this email directly or view it on GitHubhttps://github.com/scottkellum/Singularity/issues/69.

Snugug commented 12 years ago

*zoom: 1 is Clearfix IE stuff

On Nov 10, 2012, at 11:40 AM, Micah Godbolt notifications@github.com wrote:

Is zoom 1 part of a clear fix? On Nov 10, 2012 8:30 AM, "Scott Kellum" notifications@github.com wrote:

Here: https://gist.github.com/4051541

these lines should not be written on .a1-1:

overflow: hidden; *zoom: 1;

from: https://github.com/scottkellum/Singularity/blob/master/example/sass/oocss-variable-padding.scss#L15

I tried removing this: https://github.com/scottkellum/Singularity/blob/master/example/sass/oocss-variable-padding.scss#L15

and all instances for that matter, but for some reason it kept compiling with *zoom: 1 there. Driving me nuts.

— Reply to this email directly or view it on GitHubhttps://github.com/scottkellum/Singularity/issues/69.

— Reply to this email directly or view it on GitHub.

robwierzbowski commented 11 years ago

I'll fix this in https://github.com/scottkellum/Singularity/issues/78, as long as I'm in there.

scottkellum commented 11 years ago

Worrying less and less about this after seeing how gzip squashes repeated code.

robwierzbowski commented 11 years ago

Simple fix, already done. Clearfix was being applied in the float/isolation-clear mixins, and pseudo clearfix code was being applied in float/isolation-common mixins. I switched it to actual clearfix only in common.

robwierzbowski commented 11 years ago

Fixed in the above merge.