search

at-wat / hokuyo3d

A ROS driver node for VSSP protocol compliant HOKUYO 3D LIDARs
18 stars 20 forks source link

ROS2 Foxy Migration #67

Open Zaaler opened 3 years ago

Zaaler commented 3 years ago

Hello, I have converted the hokuyo 3d driver to work for Foxy ROS2. Can you create a branch for foxy-devel that I can issue a PR to?

at-wat commented 3 years ago

I think I don't have enough time to maintain ROS2 version for now, but PR is welcome. Is it ok to be ros2 branch instead of *-devel?

at-wat commented 3 years ago

It may be better to refactor the master branch code first to make it easy to share middleware independent code.

Zaaler commented 3 years ago

Hello Atsushi, I went ahead and submitted a PR. If you wanted to bring it down and test it with ROS2, it should work. This would be the first time I've submitted a PR to another person's repository on Github. Let me know what you think. Zack