at-wat / mcl_3dl

A ROS node to perform a probabilistic 3-D/6-DOF localization system for mobile robots with 3-D LIDAR(s). It implements pointcloud based Monte Carlo localization that uses a reference pointcloud as a map.
BSD 3-Clause "New" or "Revised" License
482 stars 119 forks source link

Fix ParticleFilter::resample() #233

Closed nhatao closed 5 years ago

nhatao commented 5 years ago

Closes #232

at-wat commented 5 years ago

[#599] PASSED on kinetic

All tests passed ``` build/test_results/mcl_3dl/gtest-test_chunked_kdtree.xml: 1 tests build/test_results/mcl_3dl/gtest-test_filter.xml: 3 tests build/test_results/mcl_3dl/gtest-test_imu_measurement_model_gravity.xml: 1 tests build/test_results/mcl_3dl/gtest-test_motion_prediction_model_differential_drive.xml: 4 tests build/test_results/mcl_3dl/gtest-test_nd.xml: 2 tests build/test_results/mcl_3dl/gtest-test_pf.xml: 6 tests build/test_results/mcl_3dl/gtest-test_point_cloud_random_sampler.xml: 1 tests build/test_results/mcl_3dl/gtest-test_point_types.xml: 1 tests build/test_results/mcl_3dl/gtest-test_quat.xml: 4 tests build/test_results/mcl_3dl/gtest-test_raycast.xml: 3 tests build/test_results/mcl_3dl/gtest-test_vec3.xml: 5 tests build/test_results/mcl_3dl/roslint-mcl_3dl.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_expansion_resetting_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_global_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_mcl_3dl_compat_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_tf_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_transform_rostest.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_pose.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_tf.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_expansion_resetting.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_global_localization.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_mcl_3dl_compat.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_transform_failure.xml: 1 tests Summary: 44 tests, 0 errors, 0 failures, 0 skipped ```

[#599] PASSED on melodic

All tests passed ``` build/test_results/mcl_3dl/gtest-test_chunked_kdtree.xml: 1 tests build/test_results/mcl_3dl/gtest-test_filter.xml: 3 tests build/test_results/mcl_3dl/gtest-test_imu_measurement_model_gravity.xml: 1 tests build/test_results/mcl_3dl/gtest-test_motion_prediction_model_differential_drive.xml: 4 tests build/test_results/mcl_3dl/gtest-test_nd.xml: 2 tests build/test_results/mcl_3dl/gtest-test_pf.xml: 6 tests build/test_results/mcl_3dl/gtest-test_point_cloud_random_sampler.xml: 1 tests build/test_results/mcl_3dl/gtest-test_point_types.xml: 1 tests build/test_results/mcl_3dl/gtest-test_quat.xml: 4 tests build/test_results/mcl_3dl/gtest-test_raycast.xml: 3 tests build/test_results/mcl_3dl/gtest-test_vec3.xml: 5 tests build/test_results/mcl_3dl/roslint-mcl_3dl.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_expansion_resetting_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_global_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_mcl_3dl_compat_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_tf_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_transform_rostest.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_pose.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_tf.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_expansion_resetting.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_global_localization.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_mcl_3dl_compat.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_transform_failure.xml: 1 tests Summary: 44 tests, 0 errors, 0 failures, 0 skipped ```
codecov-io commented 5 years ago

Codecov Report

Merging #233 into master will decrease coverage by 0.13%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage    89.8%   89.67%   -0.14%     
==========================================
  Files          25       25              
  Lines        1520     1520              
==========================================
- Hits         1365     1363       -2     
- Misses        155      157       +2
Impacted Files Coverage Δ
include/mcl_3dl/pf.h 97.56% <100%> (-1.63%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6eda333...c912dd0. Read the comment docs.

at-wat commented 5 years ago

[#600] PASSED on kinetic

All tests passed ``` build/test_results/mcl_3dl/gtest-test_chunked_kdtree.xml: 1 tests build/test_results/mcl_3dl/gtest-test_filter.xml: 3 tests build/test_results/mcl_3dl/gtest-test_imu_measurement_model_gravity.xml: 1 tests build/test_results/mcl_3dl/gtest-test_motion_prediction_model_differential_drive.xml: 4 tests build/test_results/mcl_3dl/gtest-test_nd.xml: 2 tests build/test_results/mcl_3dl/gtest-test_pf.xml: 6 tests build/test_results/mcl_3dl/gtest-test_point_cloud_random_sampler.xml: 1 tests build/test_results/mcl_3dl/gtest-test_point_types.xml: 1 tests build/test_results/mcl_3dl/gtest-test_quat.xml: 4 tests build/test_results/mcl_3dl/gtest-test_raycast.xml: 3 tests build/test_results/mcl_3dl/gtest-test_vec3.xml: 5 tests build/test_results/mcl_3dl/roslint-mcl_3dl.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_expansion_resetting_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_global_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_mcl_3dl_compat_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_tf_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_transform_rostest.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_pose.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_tf.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_expansion_resetting.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_global_localization.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_mcl_3dl_compat.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_transform_failure.xml: 1 tests Summary: 44 tests, 0 errors, 0 failures, 0 skipped ```

[#600] PASSED on melodic

All tests passed ``` build/test_results/mcl_3dl/gtest-test_chunked_kdtree.xml: 1 tests build/test_results/mcl_3dl/gtest-test_filter.xml: 3 tests build/test_results/mcl_3dl/gtest-test_imu_measurement_model_gravity.xml: 1 tests build/test_results/mcl_3dl/gtest-test_motion_prediction_model_differential_drive.xml: 4 tests build/test_results/mcl_3dl/gtest-test_nd.xml: 2 tests build/test_results/mcl_3dl/gtest-test_pf.xml: 6 tests build/test_results/mcl_3dl/gtest-test_point_cloud_random_sampler.xml: 1 tests build/test_results/mcl_3dl/gtest-test_point_types.xml: 1 tests build/test_results/mcl_3dl/gtest-test_quat.xml: 4 tests build/test_results/mcl_3dl/gtest-test_raycast.xml: 3 tests build/test_results/mcl_3dl/gtest-test_vec3.xml: 5 tests build/test_results/mcl_3dl/roslint-mcl_3dl.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_expansion_resetting_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_global_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_mcl_3dl_compat_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_tf_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_transform_rostest.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_pose.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_tf.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_expansion_resetting.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_global_localization.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_mcl_3dl_compat.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_transform_failure.xml: 1 tests Summary: 44 tests, 0 errors, 0 failures, 0 skipped ```
at-wat commented 5 years ago

[#602] PASSED on melodic

All tests passed ``` build/test_results/mcl_3dl/gtest-test_chunked_kdtree.xml: 1 tests build/test_results/mcl_3dl/gtest-test_filter.xml: 3 tests build/test_results/mcl_3dl/gtest-test_imu_measurement_model_gravity.xml: 1 tests build/test_results/mcl_3dl/gtest-test_motion_prediction_model_differential_drive.xml: 4 tests build/test_results/mcl_3dl/gtest-test_nd.xml: 2 tests build/test_results/mcl_3dl/gtest-test_pf.xml: 6 tests build/test_results/mcl_3dl/gtest-test_point_cloud_random_sampler.xml: 1 tests build/test_results/mcl_3dl/gtest-test_point_types.xml: 1 tests build/test_results/mcl_3dl/gtest-test_quat.xml: 4 tests build/test_results/mcl_3dl/gtest-test_raycast.xml: 3 tests build/test_results/mcl_3dl/gtest-test_vec3.xml: 5 tests build/test_results/mcl_3dl/roslint-mcl_3dl.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_expansion_resetting_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_global_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_mcl_3dl_compat_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_tf_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_transform_rostest.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_pose.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_tf.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_expansion_resetting.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_global_localization.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_mcl_3dl_compat.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_transform_failure.xml: 1 tests Summary: 44 tests, 0 errors, 0 failures, 0 skipped ```

[#602] PASSED on kinetic

All tests passed ``` build/test_results/mcl_3dl/gtest-test_chunked_kdtree.xml: 1 tests build/test_results/mcl_3dl/gtest-test_filter.xml: 3 tests build/test_results/mcl_3dl/gtest-test_imu_measurement_model_gravity.xml: 1 tests build/test_results/mcl_3dl/gtest-test_motion_prediction_model_differential_drive.xml: 4 tests build/test_results/mcl_3dl/gtest-test_nd.xml: 2 tests build/test_results/mcl_3dl/gtest-test_pf.xml: 6 tests build/test_results/mcl_3dl/gtest-test_point_cloud_random_sampler.xml: 1 tests build/test_results/mcl_3dl/gtest-test_point_types.xml: 1 tests build/test_results/mcl_3dl/gtest-test_quat.xml: 4 tests build/test_results/mcl_3dl/gtest-test_raycast.xml: 3 tests build/test_results/mcl_3dl/gtest-test_vec3.xml: 5 tests build/test_results/mcl_3dl/roslint-mcl_3dl.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_expansion_resetting_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_global_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_localization_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_mcl_3dl_compat_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_tf_rostest.xml: 1 tests build/test_results/mcl_3dl/rostest-test_tests_transform_rostest.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_pose.xml: 1 tests build/test_results/mcl_3dl/rosunit-compare_tf.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_expansion_resetting.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_global_localization.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_mcl_3dl_compat.xml: 1 tests build/test_results/mcl_3dl/rosunit-test_transform_failure.xml: 1 tests Summary: 44 tests, 0 errors, 0 failures, 0 skipped ```