at-wat
commented
4 years ago Closed nhatao closed 4 years ago
at-wat
commented
4 years ago at-wat
commented
4 years ago catkin_make tests failed
codecov-io
commented
4 years ago Merging #259 into master will increase coverage by
0.04%. The diff coverage is95.55%.
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 94.24% 94.29% +0.04%
==========================================
Files 25 28 +3
Lines 1563 1629 +66
==========================================
+ Hits 1473 1536 +63
- Misses 90 93 +3| Impacted Files | Coverage Δ | |
|---|---|---|
| ...cl_3dl/noise_generators/diagonal_noise_generator.h | 100% <100%> (ø) |
|
| src/mcl_3dl.cpp | 92.37% <100%> (-0.02%) |
:arrow_down: |
| include/mcl_3dl/pf.h | 97.79% <100%> (+0.1%) |
:arrow_up: |
| ...dl/noise_generators/multivariate_noise_generator.h | 100% <100%> (ø) |
|
| include/mcl_3dl/noise_generator_base.h | 85.71% <85.71%> (ø) |
|
| include/mcl_3dl/state_6dof.h | 95.55% <88.46%> (-1.03%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8ff9584...4dac14d. Read the comment docs.
at-wat
commented
4 years ago at-wat
commented
4 years ago 
nhatao
commented
4 years ago @at-wat Please take another look.
at-wat
commented
4 years ago at-wat
commented
4 years ago nhatao
commented
4 years ago NoiseGeneratorBase class is added, and mean is included in this class. To keep algorithm in State6DOF::generateNoise(), NoiseGeneratorBase has a getter function for mean.
@at-wat Sorry for the delay. Please take a look when you have a time.
at-wat
commented
4 years ago at-wat
commented
4 years ago nhatao
commented
4 years ago @at-wat PTAL.
at-wat
commented
4 years ago at-wat
commented
4 years ago merging
Closes #258 Closes #202