at-wat
commented
3 years ago [#847] FAILED on kinetic
catkin_make tests failed
Closed nhatao closed 3 years ago
at-wat
commented
3 years ago at-wat
commented
3 years ago catkin_make tests failed
Tested on Alpine ROS
at-wat
commented
3 years ago catkin_make tests failed
Tested on Alpine ROS
at-wat
commented
3 years ago Tested on Alpine ROS
Tested on Alpine ROS
codecov-commenter
commented
3 years ago Merging #339 into master will decrease coverage by
0.54%. The diff coverage is85.39%.
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 94.56% 94.01% -0.55%
==========================================
Files 32 34 +2
Lines 1729 1806 +77
==========================================
+ Hits 1635 1698 +63
- Misses 94 108 +14 | Impacted Files | Coverage Δ | |
|---|---|---|
| ..._measurement_models/lidar_measurement_model_beam.h | 100.00% <ø> (ø) |
|
| ...rement_models/lidar_measurement_model_likelihood.h | 100.00% <ø> (ø) |
|
| include/mcl_3dl/parameters.h | 100.00% <ø> (ø) |
|
| include/mcl_3dl/point_cloud_random_sampler.h | 100.00% <ø> (ø) |
|
| src/mcl_3dl.cpp | 90.18% <30.00%> (-1.02%) |
:arrow_down: |
| ..._random_samplers/point_cloud_sampler_with_normal.h | 90.47% <90.47%> (ø) |
|
| include/mcl_3dl/lidar_measurement_model_base.h | 100.00% <100.00%> (ø) |
|
| ...loud_random_samplers/point_cloud_uniform_sampler.h | 100.00% <100.00%> (ø) |
|
| src/lidar_measurement_model_beam.cpp | 98.48% <100.00%> (ø) |
|
| src/lidar_measurement_model_likelihood.cpp | 94.73% <100.00%> (ø) |
|
| ... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8349804...90d779f. Read the comment docs.
nhatao
commented
3 years ago @at-wat PTAL.
at-wat
commented
3 years ago Tested on Alpine ROS
at-wat
commented
3 years ago Tested on Alpine ROS
nhatao
commented
3 years ago @at-wat Please take another look.
When the first principal component of particle positions are much larger than the second, PointCloudSamplerWithNormal selectively samples scan points that have small angular difference between their normals and the first principal component. After a robot moves along a long corridor without features to estimate travel distance, particles can be converged quickly with this algorithm soon after the robot finds a side way.