at-wat
commented
3 years ago [96] FAILED on melodic
catkin_make failed
[96] FAILED on noetic
catkin_make failed
Closed remco-r closed 3 years ago
at-wat
commented
3 years ago catkin_make failed
catkin_make failed
at-wat
commented
3 years ago 
codecov-commenter
commented
3 years ago Merging #381 (dbcafad) into master (9e13130) will decrease coverage by
0.63%. The diff coverage is53.57%.
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 94.19% 93.56% -0.64%
==========================================
Files 32 32
Lines 1896 1912 +16
==========================================
+ Hits 1786 1789 +3
- Misses 110 123 +13 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/mcl_3dl.cpp | 89.48% <53.57%> (-1.51%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9e13130...dbcafad. Read the comment docs.
at-wat
commented
3 years ago at-wat
commented
3 years ago at-wat
commented
3 years ago 
remco-r
commented
3 years ago I have rebased on master, and removed the .rosinstall commit
at-wat
commented
3 years ago at-wat
commented
3 years ago
This PR is accompanied by a service definition in mcl_3dl_msgs: https://github.com/at-wat/mcl_3dl_msgs/pull/30
The map to localize in was previously loaded with a sensor_msgs::PointCloud2 topic. It was not guaranteed that the map was actually loaded with a single publish on the topic. Also it was overkill if you had a pcd you wanted to localize in, because you would have to convert it first to a PointCloud2, then publish it, and then it would be converted in mcl_3dl to a PCL cloud.
This PR implements loading a pcd file by file path, directly into mcl_3dl.