at-wat
commented
1 year ago Closed nhatao closed 1 year ago
at-wat
commented
1 year ago 
codecov-commenter
commented
1 year ago Merging #705 (c189a14) into master (4c9f1a3) will increase coverage by
0.18%. The diff coverage is88.57%.
@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 88.13% 88.31% +0.18%
==========================================
Files 60 60
Lines 4323 4330 +7
==========================================
+ Hits 3810 3824 +14
+ Misses 513 506 -7 | Impacted Files | Coverage Δ | |
|---|---|---|
| planner_cspace/src/planner_3d.cpp | 85.13% <88.23%> (+1.17%) |
:arrow_up: |
| planner_cspace/src/patrol.cpp | 89.28% <100.00%> (ø) |
at-wat
commented
1 year ago 
nhatao
commented
1 year ago There is still a problem. Changed to WIP
at-wat
commented
1 year ago at-wat
commented
1 year ago at-wat
commented
1 year ago catkin_make tests failed
at-wat
commented
1 year ago catkin_make tests failed
at-wat
commented
1 year ago at-wat
commented
1 year ago at-wat
commented
1 year ago
In the current master branch, When
cnt_stuck_has a positive value,status.errorbecomesPATH_NOT_FOUND. The value ofcnt_stuck_is incremented when the start or the goal cell is occupied, and it is retained even after the occupied cell is cleared and path planning is succeeded. Therefore, thestatus.errornever returns toGOING_WELLin such cases. In addition, when the start cell is occupied,status.errorshould becomeIN_ROCK. This bug is introduced by https://github.com/at-wat/neonavigation/commit/db2532967d0e15f85e7ee8657183abddcb1719ea.In this PR,
cost_estim_cache_created_is used to check if the start or goal cell is occupied instead ofcnt_stuck_. In addition,is_start_occupied_flag is added to distinguishIN_ROCKstatus. Some inappropriate names of functions and variables are renamed.