search

at0dd / tesla-api

An unofficial .NET implementation of the Tesla API.
https://www.nuget.org/packages/Tesla-API/
MIT License
15 stars 14 forks source link

ChargeAmps is missing from ChargeState and exceptions with reply from GetVehicleState #34

Closed tagevm closed 2 years ago

tagevm commented 2 years ago

Nice job with the api, I found a few issues:

ChargeState is missing ChargeAmps property Numerous properties should be nullable MinimumLimitMilesPerHour should be null

tagevm commented 2 years ago

Actually, I have solved the issue locally, but I don't seem to be able to figure out how to create a branch and submit a pull request

claudiosanchez commented 2 years ago

You will first want to fork the repo, and then submit a pull request. I hope this helps. @tagevm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

at0dd commented 2 years ago

It's been a busy few months, but I'm working on getting this fixed and adding some tests.