search

ata4 / angrylion-rdp-plus

A low-level N64 video emulation plugin, based on the pixel-perfect angrylion RDP plugin with some improvements.
155 stars 25 forks source link

cmake: git improvements #132

Closed orbea closed 2 years ago

orbea commented 2 years ago

This PR does the following:

Caveat:

The GIT_TAG format changes, it doesn't seem trivial to remove the git commit hash from the git tag.

Alternatively I could drop the number of commits since the last tag with --abbrev=0.

Maybe someone better with cmake could replicate what the python script is doing?

orbea commented 2 years ago

@ata4 When you have a chance I would really appreciate if you could review this, thanks!

ata4 commented 2 years ago

Sorry for the delay, I'll review the request soon.

ata4 commented 2 years ago

Okay, looks good to me. It certainly helps to get rid of one build dependency. Thanks!