Closed orbea closed 2 years ago
@ata4 When you have a chance I would really appreciate if you could review this, thanks!
Sorry for the delay, I'll review the request soon.
Okay, looks good to me. It certainly helps to get rid of one build dependency. Thanks!
This PR does the following:
Caveat:
The
GIT_TAG
format changes, it doesn't seem trivial to remove the git commit hash from the git tag.v1.6-5
orv1.6-5-dirty
v1.6-5-g1145315
orv1.6-5-g1145315-dirty
Alternatively I could drop the number of commits since the last tag with
--abbrev=0
.v1.6
orv1.6-dirty
Maybe someone better with cmake could replicate what the python script is doing?