search

ata4 / angrylion-rdp-plus

A low-level N64 video emulation plugin, based on the pixel-perfect angrylion RDP plugin with some improvements.
158 stars 25 forks source link

CI/CD: Implement GitHub Actions and public nightly builds #134

Closed Jj0YzL5nvJ closed 2 years ago

Jj0YzL5nvJ commented 2 years ago

This implementation has a small detail... it will be necessary to delete the nightly-build tag from the local repository as part of the build process to generate the correct version number.

Check out my nightly-build for reference. I needed to delete nightly-build and v1.6-1 to generate the correct version number before the build process.

ata4 commented 2 years ago

Thanks, that looks helpful. I was already trying to figure out the basics of Github Actions, this will save me a lot of work!

Jj0YzL5nvJ commented 2 years ago

The nightly-build tag is auto-generated, don't push said tag to github or you will duplicate the workflow unnecessarily. It's better to delete it from your local repository and never sync with it.

ata4 commented 2 years ago

The pipeline for Linux build exited with an error without the tag, though. It started to work fine after adding and pushing it manually.

Jj0YzL5nvJ commented 2 years ago

Yeah... I theorized that error and wrote the logic so that the error didn't occur in batch but I forgot that bash would capture an error code with such logic.