[Regression] Invisible Nintendo logo text

ata4 / angrylion-rdp-plus

A low-level N64 video emulation plugin, based on the pixel-perfect angrylion RDP plugin with some improvements.

155 stars 25 forks source link

[Regression] Invisible Nintendo logo text #138

Closed GhostlyDark closed 2 years ago

GhostlyDark commented 2 years ago

Ocarina of Time and Majora's Mask are affected.

Nightly https://github.com/ata4/angrylion-rdp-plus/commit/6660e93acc94506933238c9a593494684d0d3bde

v1.6 looked normal.

ata4 commented 2 years ago

Can confirm, I believe it was caused by d95d3aa1bfc2c0812e70258fd9fa66bb5dd183a9. I'll take a look.

ata4 commented 2 years ago

Finally found the error: it was a missing z_compare call in render_spans_2cycle_complete. I'll check the other functions as well in case there are more regressions.