ata4 / angrylion-rdp-plus

A low-level N64 video emulation plugin, based on the pixel-perfect angrylion RDP plugin with some improvements.
158 stars 25 forks source link

Unfiltered aspect ratio messed up #23

Closed Phanatical closed 7 years ago

Phanatical commented 7 years ago

I noticed in various games I've tried that if you use unfiltered the aspect ratio goes all wonky. Indiana Jones and The Infernal Machine it stretches to a strange vertical aspect. Supercross 2000 it goes into an ultra widescreen view. These are just a couple examples, seems okay in Goldeneye and other games.

project64 2017-09-29 10-27-18-07 project64 2017-09-29 10-28-58-50

With filtered, aspect ratio remains perfectly intact. So I don't know why this happens.

theboy181 commented 7 years ago

Are you using current build?

Phanatical commented 7 years ago

Yes, the Sep 29 build off emucr. I don't know how to compile myself. Also using latest Project64 and rsp.

theboy181 commented 7 years ago

Looks like your correct, about it not working in latest. I'm sure it will get fixed soon.

loganmc10 commented 7 years ago

Same issue in mupen64plus, lastest master

Phanatical commented 7 years ago

I just checked through all of the main releases so far and it looks like this issue has always existed with unfiltered. Would be great if this were fixable.

theboy181 commented 7 years ago

Goldeneye is fixed with the current build. It used to make the window size change.

Phanatical commented 7 years ago

Yeah this problem doesn't seem to affect every game for some reason. Hopefully this and some performance issues with certain titles can be ironed out. Some games run full speed, others like Roadsters Trophy run at around 51fps even on an overclocked 4670k.

ata4 commented 7 years ago

The plugin currently doesn't support aspect ratio correction for unfiltered output, so if a game decides to render with double/half vertical or horizontal resolution, the output is distorted. I hope I eventually understand the VI well enough to get rid of the overscan and obtain the correct aspect ratio at the same time.

Phanatical commented 7 years ago

Good luck, hope you can get it figured out. Really prefer using unfiltered. Can't you contact angrylion himself for help on this? I noticed his sourceforge page appears to be updated regularly so I'm guessing he's still around:

https://sourceforge.net/p/angrylions-stuff/activity/?page=0&limit=100#59cd08e45fcbc937826ed3db

theboy181 commented 7 years ago

We should send him the invite to D if you think he would except.

ata4 commented 7 years ago

For now, I'm simply locking the aspect ratio to 4:3 (or 16:9 with widescreen option enabled). I know it's not really the correct way to fix it, but after spending several hours studying the VI registers and angrylion's code, this seems to be the most convenient solution.