search

ata4 / angrylion-rdp-plus

A low-level N64 video emulation plugin, based on the pixel-perfect angrylion RDP plugin with some improvements.
158 stars 25 forks source link

Build failure #34

Closed loganmc10 closed 7 years ago

loganmc10 commented 7 years ago 
vi.c(750): error C2220: warning treated as error - no 'object' file generated [C:\mg\angrylion-rdp-plus\core\core.vcxproj]
vi.c(750): warning C4098: 'vi_update': 'void' function returning a value [C:\mg\angrylion-rdp-plus\core\core.vcxproj]

Mupen64plus build in Visual Studio

loganmc10 commented 7 years ago

I believe this is the offending line:

https://github.com/ata4/angrylion-rdp-plus/blob/master/core/vi.c#L750

return 0 should be return in a void function @ata4

loganmc10 commented 7 years ago

I'm on my phone, I'll submit a PR tomorrow if it hasn't been fixed by then

ghost commented 7 years ago

I don't know how it came to be like this?

It's sad really and I thought we all strived for one thing, having fun and play games but that must have changed drastically and I'm having no fun at all when we have this attitude to each other @twinaphex

Anyway I have submitted a PR that hopefully fixes this, if it's good then merge it.

I really hope we can get along and start having fun again, I for one just want to play my games and not have silly arguments all the time that contributes with nothing.