search

ata4 / disunity

An experimental toolset for Unity asset and asset bundle files.
The Unlicense
2.7k stars 663 forks source link

Use jitpack.io for github deps, remove submodules #97

Closed moshen closed 9 years ago

moshen commented 9 years ago

jitpack namespaces the github dependencies under com.github.ata4, ensuring there are no conflicts. Allows someone to build using a simple mvn package.

You probably want to create releases of lzmajio and ioutils to have something to pin builds to.

Also... removing submodules is a little finnicky. You may need to rm -rf .git/modules/lib/{ioutils,lzmajio} to complete the removal.

ata4 commented 9 years ago

Sounds like a better solution than the previous one. However, I'm still not used to Maven, so I'll need some time to figure out how to migrate my projects and libraries.

moshen commented 9 years ago

jitpack.io is nice because it doesn't require you to run through mvn release or mvn deploy. For someone unfamiliar with maven, all it requires for a "release" is to create a github release (tagged release, which you're already doing for disunity... but not for ioutils or lzmajio).

Alternatives for hosting maven artifacts are: bintray.com and plain ol' Maven Central (though, they have some requirements for releases)

You mentioned in: ata4/disunity/issues/99 that you are refactoring ioutils, that will break this build as jitpack is pulling the HEAD of master. You can fix this by creating a tagged release of ioutils and referencing that in pom.xml.