Fix COMPARE_OP for when obj is None

atabac / python-on-a-chip

Automatically exported from code.google.com/p/python-on-a-chip

Other

0 stars 0 forks source link

Fix COMPARE_OP for when obj is None #184

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Reported by Oscar on the maillist on 2011/01/30.

He's unable to compare against None using the "is" operator.

Original issue reported on code.google.com by dwhall...@gmail.com on 30 Jan 2011 at 5:46

GoogleCodeExporter commented 9 years ago

Original comment by dwhall...@gmail.com on 7 May 2011 at 7:52

Changed state: Started

GoogleCodeExporter commented 9 years ago

- Added system test based on cases Oscar sent by email and added some of my own.
- Modified COMPARE_OP bytecode in interp.c to handle OBJ_TYPE_NON and compare 
types COMP_IS and COMP_IS_NOT.

Original comment by dwhall...@gmail.com on 7 May 2011 at 8:14

GoogleCodeExporter commented 9 years ago

This issue was closed by revision c048c00cef12.

Original comment by dwhall...@gmail.com on 7 May 2011 at 8:15

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

This issue was closed by revision bea5b5757853.

Original comment by dwhall...@gmail.com on 7 May 2011 at 8:25

GoogleCodeExporter commented 9 years ago

Grr... the fix above breaks system test t020.  Trying again.

Original comment by dwhall...@gmail.com on 7 May 2011 at 8:45

Changed state: Started

GoogleCodeExporter commented 9 years ago

In branch default:
- Fixed logic so t020 passes again.
Checkin: r02e194f5bc84  

In branch v10:
- Fixed logic so t020 passes again.
- Added t384 to runtests.c in 
- Removed t384.c
Checkin: r5acf689761a8

Original comment by dwhall...@gmail.com on 7 May 2011 at 10:23

Changed state: Fixed