search

atac / c10-tools

Commandline toolkit for inspecting and troubleshooting IRIG 106 Chapter 10/11 data with pychapter10.
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Reimplement CLI with click to improve instantiation time. #22

Closed mcferrill closed 2 years ago

mcferrill commented 2 years ago

@dglowe could you review the corresponding branch and see if the change makes sense? As best I can tell there's not really a performance gain, but click is definitely more extensible/modular so I tend to say let's make the switch.

dglowe commented 2 years ago

Agreed. Wouldn't say a performance gain, but - after reviewing code and using - from dev and user standpoint, seems an overall better experience. I think make the switch.

dglowe commented 2 years ago

@mcferrill Didn't mean to close with comment. I see the corresponding branch is one commit behind master. I think if there are no conflicts after catching up with master, it's ready to merge. Want me to do that so your time can be otherwise used?

mcferrill commented 2 years ago

Sounds good

dglowe commented 2 years ago

Question - when you run pytest on 09fde994d6afb1a45c40fa309e1286168553db8c 'remove docopt', do your tests pass? If so I have something weird happening with my environment. Else I can work on getting tests to pass. Just trying to lock in on next action to take.

mcferrill commented 2 years ago

Did you 'pdm install' before testing?

dglowe commented 2 years ago

I did.