search

atagulalan / arctis-battery-percentage

🔋 Shows SteelSeries Arctis wireless device's battery percentages as a notification.
MIT License
70 stars 16 forks source link

New write bytes for Arctis 9 and new Arctis Series #11

Closed warpunish closed 3 years ago

warpunish commented 4 years ago

It seems steel series changed request bytes in new productions of arctis devices

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

centic9 commented 4 years ago

I am not the owner of this project but your PR would probably break support for all other Arctis models...

atagulalan commented 4 years ago

Hello @warpunish

Thank you for your contribution. This change would break all other Arctis headsets. Could you implement a check for device id?

Thank you.

warpunish commented 4 years ago

@atagulalan I did this following a blog that you posted on another issue. It seems they didn't change device id just the write byte and response index. I could check if there is a validation for newer products when i have free time. Until that time people can use this fork if they have purchased a new line of products, i guess. Don't mind the PR right now.

atagulalan commented 3 years ago

I am merging this, thank you for your contribution!