wennergr commented 6 years ago

Use standard functions from cats when converting from Try to Either

This PR should not actually change functionality except that only non fatal exceptions are caught (feel more correct to me).

The primary reason for this PR is to avoid future divergent implicits as cats already defines toOption and toEither in the standard syntax for Either.

codecov[bot] commented 6 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      7    -1     
  Lines         103     99    -4     
  Branches        1      1           
=====================================
- Hits          103     99    -4

Impacted Files	Coverage Δ
src/main/scala/com/github/atais/util/Read.scala	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3130e53...c2e5dff. Read the comment docs.

atais commented 6 years ago

lgtm :+1: i will merge it and release shortly.

atais / Fixed-Length

Use standard functions from cats when converting from Try to Either #10

Codecov Report