search

atais / ng2-eonasdan-datetimepicker

A wrapper directive around the Eonasdan Datepicker v4 component.
MIT License
34 stars 23 forks source link

Fixes a bug where if the initial value was null it threw an exception #12

Closed 4-Eyes closed 7 years ago

4-Eyes commented 7 years ago

Basically it just wasn't checking to see if the date existed before trying to get its value.

atais commented 7 years ago

Well, could help :+1:

I would merge it, but I am not able to test is. I do not work with angular2 (and angular at all) anymore. Does anyone need it :question:

4-Eyes commented 7 years ago

Yeah, I would use it

atais commented 7 years ago

Ok it will try to release a version with this fix today or tomorrow

atais commented 7 years ago

@4-Eyes whoa sorry, I had to revert the changes.

Actually, the project is so old that when I tried building it now it failed! 😢 If you can run rpm run build and generate the sources I would be glad to push it to the npm but currently the project did not work at all for me.

What is worse, I do not want to waste time on checking it since I am so out of date with all this stuff.

atais commented 7 years ago

@4-Eyes if you could build the app I will merge your changes.

4-Eyes commented 7 years ago

I've just built it and pushed the changes. I'm going to make sure that it wasn't just working on one machine.

4-Eyes commented 7 years ago

Yeah, looks like it should build. Just had some outdated packages in it.

atais commented 7 years ago

Please create new Pull Request. Thanks