atampy25 / simple-mod-framework

GNU Lesser General Public License v3.0
61 stars 40 forks source link

[Issue Report] Jax765: mod manager problem #675

Open simple-mod-framework[bot] opened 11 months ago

simple-mod-framework[bot] commented 11 months ago

Metadata

Reported by: @Jax765

Type of issue: Mod manager problem

Platform: Steam

OS version: Windows 10 Home (22H2)

Game version: 3.170.0

SMF version: 2.33.3

Notes

When installing certain mods like Misc Outfit Mesh and Texture fixes and REi, the deployment gets stuck for an extremely long time while it produces warning messages, far in excess of the final deployment time that's given when completed (for instance, it can sometimes go as long as half an hour, while SMF reports that deployment took between 2-10 minutes). At least one mod author has mentioned that this warning message thing is what causes the deployment operation to keep going unnecessarily, far after the mods have actually been installed.

atampy25 commented 11 months ago

That's just entirely untrue.

Jax765 commented 11 months ago

Yes, my own experience where the deployment process keeps going for half an hour, then when it completes, it claims that it only took 10 minutes, is entirely made up, because I have so much to gain by lying about an issue with a mod tool 🙄

atampy25 commented 11 months ago

No, what the mod authors have told you about warnings being generated after the mods are applied is untrue, because the framework generates warning message UI elements in real time and warnings themselves typically at the start of the deployment, not the end.

I don't doubt that you are experiencing delays, but I need you to actually explain what happens and when rather than repeating something that some unaffiliated mod developer has said. When is there a delay? Is there an associated freeze (i.e. the UI stops responding to input)? What is the last message in the deploy log when it happens?

atampy25 commented 11 months ago

Additionally, what system are you running? OS, laptop/desktop, power status, antivirus, etc. can all affect it.

Jax765 commented 11 months ago

Windows 10 on desktop. AV-wise, I just have malwarebytes running.

Running another deployment right now. So the log in the program itself goes on for a very long time with warnings about how Misc Outfit Mesh and Texture fixes replaces base game entity files. It's still going right now, generating new warnings for each individual file from that mod seemingly, but the actual log claims that it's already done. So it doesn't freeze, but it does very slowly generate warnings for each individual file from particular mods.

Checking the rest of my game directory, literally nothing else has been modified since the log finished up about 4 minutes ago, yet the SMF GUI is still acting as if it's not done yet. So this lines up exactly with what I was told by a mod author. The deployment is done according to the log file, but the program keeps going, very slowly generating warnings long afterwards. Deploy.log Screenshot 2023-10-29 094113

atampy25 commented 11 months ago

What is at the end of the SMF GUI's log? The only way I could see this happening is if performance has been really impacted on the computer, or if the mod is somehow producing millions of warnings to the point that it causes performance issues and SMF can't even process the rest of the log.

Jax765 commented 11 months ago

Ok, so the SMF GUI finally finished, 14 minutes after the log file last updated. Also, I uploaded my log in the previous post. The last line is "INFO Deploy Done in 1m42s". Again, not a single file in my game directory was modified after the log was last updated 14 minutes prior to SMF's GUI claiming it was done. It seems as though the GUI is heavily delayed in displaying the warnings, whereas the log file produces them expontentially faster. The deployment appears to be done far in advance of the GUI saying so. Screenshot 2023-10-29 095240

For reference, my hardware is as follows: CPU - Intel 12700k GPU - RTX 3080 RAM - 32GB SSD - WD SN850 NVME

atampy25 commented 11 months ago

I mean the last line of the GUI log while it's going slowly after the underlying deploy has finished.

Jax765 commented 11 months ago

It's the part where it's giving warnings about replacing base game entities in the Misc Outfit Mesh & Texture Fixes mod that I provided a screenshot of.

atampy25 commented 11 months ago

So the new lines that come up slowly are just warning lines (your screenshot was slightly scrolled up because the framework doesn't autoscroll to the very last line)? That would mean that the GUI is processing them individually really slowly. That's quite odd.

atampy25 commented 11 months ago

Ah. The mod is producing thousands of warnings, so I think the GUI is struggling to render them (since it's Electron, which is like a web browser), causing each frame to add delay and desyncing from the actual deploy. Ideally the solution to this would be to fix the mod so it doesn't do that, but I doubt the mod author is going to do that if they let it get this bad. I'll look into fixing this, maybe by hiding warnings past a certain amount.

Jax765 commented 11 months ago

Ok, thanks.