search

atanasster / storybook-addon-deps

A storybook addon to add a dependencies tree exporer tab.
https://atanasster.github.io/storybook-addon-deps/?path=/docs/design-system-avatarlist--short
MIT License
59 stars 3 forks source link

Dependencies not found (React) #2

Closed donaldpipowitch closed 4 years ago

donaldpipowitch commented 4 years ago

Thank you very much for this addon. I tried it out in our codebase, but it didn't seem to work. I created a small demo project to show that dependencies are not found. https://github.com/donaldpipowitch/storybook-addon-deps-bug

$ git clone https://github.com/donaldpipowitch/storybook-addon-deps-bug.git && cd storybook-addon-deps-bug && yarn && yarn install

Any idea why? I thought I configured everything correctly.

Thank you :)

roman-balzer commented 4 years ago

Also not working for me.

Deps Tab is also showing following Image

donaldpipowitch commented 4 years ago

@roman-balzer Seems to be a different issue however.

atanasster commented 4 years ago

Thanks a lot, i will check your repro today.

@roman-balzer - can you point me also to a repro.

atanasster commented 4 years ago

@donaldpipowitch really sorry for the delay, i was pretty busy and hope to get to your repo this week.

As a compensation, i will share here first what I have been busy with - “1-line functional testing”

https://gifyu.com/image/qtbT

donaldpipowitch commented 4 years ago

Don't worry take the time you need. And niiiiice idea with the one line controls 👍

atanasster commented 4 years ago

@donaldpipowitch - found it, by default the plugin filters stories as the usual names (stories.tsx etc). You ca change the filtering options from the options of storybook-dep-webpack-plugin, but i completely forgot to list the options in the readme, So I have now updated the readme - can you please check the last section Options.filter - and you should be able to adjust the re mask to your needs,

If not, the easiest 'fix' would be to rename your stories to the default naming too :)

Anyway, here is a screenshot of the addon working now:

grab45

atanasster commented 4 years ago

If you also want to play with how much details to display, you can use more of a docs-only type setup like here:

https://github.com/storybookjs/design-system/blob/57cc9176a788efae9330a348744ed22114360b40/.storybook/preview.js#L14

donaldpipowitch commented 4 years ago

I'll close for now as this will probably solve my issue. Thanks!

Were there any reasons to have default filtering at all instead of allowing all stories?