atanisoft / ESP32CommandStation

An ESP32 based DCC Command Station with integrated OpenLCB (LCC) --- NOTE: this project is not under active development.
https://atanisoft.github.io/ESP32CommandStation/
GNU General Public License v3.0
90 stars 34 forks source link

Disabling legacy DCC++ support throws an error #51

Closed TrainzLuvr closed 4 years ago

TrainzLuvr commented 4 years ago

I thought I could disable the legacy DCC++ support, but I got this error:

../components/JmriInterface/JmriInterface.cpp: In lambda function:
../components/JmriInterface/JmriInterface.cpp:37:28: error: 'CONFIG_JMRI_LISTENER_PORT' was not declared in this scope
         new SocketListener(CONFIG_JMRI_LISTENER_PORT,
                            ^~~~~~~~~~~~~~~~~~~~~~~~~
../components/JmriInterface/JmriInterface.cpp:37:28: note: suggested alternative: 'CONFIG_FMB_TIMER_GROUP'
         new SocketListener(CONFIG_JMRI_LISTENER_PORT,
                            ^~~~~~~~~~~~~~~~~~~~~~~~~
                            CONFIG_FMB_TIMER_GROUP
../components/JmriInterface/JmriInterface.cpp:50:9: error: 'CONFIG_JMRI_MDNS_SERVICE_NAME' was not declared in this scope
         CONFIG_JMRI_MDNS_SERVICE_NAME, CONFIG_JMRI_LISTENER_PORT);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../components/JmriInterface/JmriInterface.cpp:50:9: note: suggested alternative: 'CONFIG_MDNS_MAX_SERVICES'
         CONFIG_JMRI_MDNS_SERVICE_NAME, CONFIG_JMRI_LISTENER_PORT);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         CONFIG_MDNS_MAX_SERVICES
../components/JmriInterface/JmriInterface.cpp: In lambda function:
../components/JmriInterface/JmriInterface.cpp:59:9: error: 'CONFIG_JMRI_MDNS_SERVICE_NAME' was not declared in this scope
         CONFIG_JMRI_MDNS_SERVICE_NAME);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../components/JmriInterface/JmriInterface.cpp:59:9: note: suggested alternative: 'CONFIG_MDNS_MAX_SERVICES'
         CONFIG_JMRI_MDNS_SERVICE_NAME);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         CONFIG_MDNS_MAX_SERVICES
[34/112] Building CXX object esp-idf/main/CMakeFiles/__idf_main.dir/ESP32CommandStation.cpp.obj
ninja: build stopped: subcommand failed.
ninja failed with exit code 1
atanisoft commented 4 years ago

Hmm, looks like it is missing an ifdef check in there. Will push a fix in a bit.