search

atanunq / viu

Terminal image viewer with native support for iTerm and Kitty
MIT License
2.53k stars 56 forks source link

Gradients are of lower quality than the demo in several 24bit colour terminals on SailfishOS #44

Closed Kabouik closed 4 years ago

Kabouik commented 4 years ago

I discovered today that I can use viu on my device, very happy! However, the resolution seems lower than expected compared to the examples, despite two of the four terminals I tested having 24bit colour support (I'm not sure about the two others). Here are some screenshots to illustrate the issue:

Some test scripts first in the most modern terminal, havoc: Screenshot_20200603_005

bfa.jpg in havoc, Fingerterm, Toeterm Literm (from left to right): Screenshot_20200603_009

havoc and Literm are the two terminals with confirmed 24bit colour; the two others probably support fewer colours, as can already be seen here on the thumnails, so I won't post additional screenshots for them.

bfa.jpg in havoc: Screenshot_20200603_008

bfa.jpg in Literm: Screenshot_20200603_013

This is close to what I can see in the demo in the README, but there still is an issue with gradients compared to the demo: ss-2020-06-03_045215

The issue is most obvious when using lights.jpg: Screenshot_20200603_007

lights.jpg shows similarly in all terminal (and a little worse in the two with inferior color support).

I am not sure whether the issue is on viu`'s side, but since it happens in all terminals I tested, I figured it was worth asking. This could be related to the OS too, but I don't know what could cause that if the terminal support all colours requiredfor the best result.

Also, note the lines showing alternatively in havoc. It only happens in that one so obviously it's not a viu bug, but perhaps you would know what viu is using that may be poorly supported in havoc?

Kabouik commented 4 years ago

That was me being stupid and thinking $COLORTERM was set automatically on the system. I read the README too fast. I'm sorry. Works pretty well with export COLORTERM=24bit (except for those lines in havoc, but that's not a viu issue.