search

atanunq / viu

Terminal image viewer with native support for iTerm and Kitty
MIT License
2.53k stars 56 forks source link

AVIF support #57

Open zaari opened 3 years ago

zaari commented 3 years ago

Please, add support for AVIF image format.

zaari commented 3 years ago

Probably depends on this issue: https://github.com/image-rs/image/issues/1152

azzamsa commented 3 years ago

Indeed.

❯ viu  foo.heic
"foo.heic": Image error: The image format could not be determined
DCjanus commented 8 months ago

I was trying to add feature flag avif-decode in viuer, but it's hard to build on my MacBook.

diff --git a/Cargo.toml b/Cargo.toml
index ebea519..1bf06bb 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -16,7 +16,7 @@ exclude = [".github"]
 termcolor = "1.1"
 crossterm = "0.27"
 ansi_colours = "1.0"
-image = "0.24"
+image = { version = "0.24",features = ["avif-decoder", "avif"] }
 base64 = "0.21.4"
 tempfile = "3.1"
 console = { version = "0.15", default-features = false }

And I was found the crate libavif-image, which is much easier to build, but looks like that there would be a lot of changes in viu and viuer, since we have to detect image format first, and decode it in different way.

bjeanes commented 1 month ago

Probably depends on this issue: image-rs/image#1152

This looks resolved now. https://github.com/image-rs/image/pull/1398

Does that unblock support in viu?