search

atanunq / viuer

Rust library for displaying images in the terminal.
MIT License
241 stars 43 forks source link

Support terminals in raw mode #24

Closed lilithium-hydride closed 3 years ago

lilithium-hydride commented 3 years ago

Add a carriage return on every newline to properly print block images when the terminal is in raw mode. Fixes #23

atanunq commented 3 years ago

Thank you for the PR! It appears that some tests are failing, do you mind fixing them? I can push the fixes to the PR, if you'd like.

Also, I'm curious - is there a reason you use raw mode? Is it your default? Are there any benefits to that?

lilithium-hydride commented 3 years ago

I'm afraid I don't know how to fix the tests, very sorry about that. I'm only using raw mode because I'm using this in a small project I started in order to familiarize myself with Rust and I can't easily accomplish what I need to outside of raw mode through Termion.

EDIT: Messing around with the tests locally, I'll fix it.

atanunq commented 3 years ago

Thanks!