search

atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)
https://atar-axis.github.io/xpadneo/
GNU General Public License v3.0
2.01k stars 113 forks source link

hid_xpadneo, quirks: Add "8Bitdo SF30 pro" #200

Closed friesnadrink closed 4 years ago

friesnadrink commented 4 years ago

Sorry if this isn't the right way to do this. It is probably all 8Bitdo controllers with an xbox mode that will need the same quirk entry. I don't have the exact string for any others, so I didn't include them.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit dd7423f0 and detected 0 issues on this pull request.

View more on Code Climate.

kakra commented 4 years ago

Can you confirm the name string for this particular model (without the + and with lower case do)?

kakra commented 4 years ago

I guess it would make more sense to match the OUI of that manufacturer instead of trying to match each model name... I'll push another PR.

Sorry if this isn't the right way to do this. It is probably all 8Bitdo controllers with an xbox mode that will need the same quirk entry. I don't have the exact string for any others, so I didn't include them.

No sorry please, that's exactly the right way to do it, tho I'll probably obsolete your commit with my next PR. ;-)

kakra commented 4 years ago

@friesnadrink Could you try with my #201 instead? It should match any 8BitDo-made controller.