trigger rumble mode setting not reflected in conf

atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)

https://atar-axis.github.io/xpadneo/

GNU General Public License v3.0

2.01k stars 113 forks source link

trigger rumble mode setting not reflected in conf #256

Closed k9bbzJavftZaqAqSW3dY closed 3 years ago

k9bbzJavftZaqAqSW3dY commented 3 years ago

Content of my /etc/modprobe.d/99-xpadneo-options.conf options hid_xpadneo disable_ff=0 disable_deadzones=0 rumble_attenuation=0 combined_z_axis=n

What it should be: options hid_xpadneo **trigger_rumble_mode**=0 disable_deadzones=0 rumble_attenuation=0 combined_z_axis=n

kakra commented 3 years ago

Yeah, I'm currently too ~~lazy~~busy to patch that, and I don't like the code duplication in the script too much anyways. Feel free to submit a PR, or wait until I got some time to redo the configuration script. Thanks. 😊

ipkpjersi commented 3 years ago

Uhh.. correct me if I'm mistaken @k9bbzJavftZaqAqSW3dY but shouldn't disable_ff just be removed outright? There's already trigger_rumble_mode in the two examples you posted so now you're just displaying it twice.

k9bbzJavftZaqAqSW3dY commented 3 years ago

@ipkpjersi You're right there, it's a mistake I made posting this bug report, as I fixed it for myself already but thought I'd drop a line here to help others - but then I got it wrong doing the copy paste. I'm fixing it in the OP