Don't disable ERTM if kernel 5.12 or later

atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)

https://atar-axis.github.io/xpadneo/

GNU General Public License v3.0

1.92k stars 111 forks source link

Don't disable ERTM if kernel 5.12 or later #288

Closed Mikaka27 closed 3 years ago

Mikaka27 commented 3 years ago

Removed disabling of ERTM only from dkms.post_install, I left dkms.post_remove alone. Reasoning for this was, that user could have installed xpadneo on older kernel, updated their kernel to 5.12 or later, and did an "sudo ./update.sh", which has to remove old ERTM override.

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit d55e9707 and detected 0 issues on this pull request.

View more on Code Climate.

Mikaka27 commented 3 years ago

I've updated the pull request according to your comments. It's better that way.

kakra commented 3 years ago

Can you squash both commits?

Mikaka27 commented 3 years ago

Just did :)