search

atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)
https://atar-axis.github.io/xpadneo/
GNU General Public License v3.0
1.92k stars 111 forks source link

dkms: Explicitly add version to the install phase #324

Closed kakra closed 2 years ago

kakra commented 2 years ago

DKMS 3 requires passing the version to BOTH the install and uninstall phase and we omitted it from the install phase.

lights0123 commented 2 years ago

This does work.

* verbose mode enabled
+ source lib/installer.sh
++ '[' 0 -ne 0 ']'
+++ git rev-parse --show-toplevel
++ GIT_ROOT=/home/$USER/.src/xpadneo
+++ __version
+++ git describe --tags --dirty
++ VERSION=v0.9-92-g15319e2
+++ type -p dkms
++ DKMS_BIN=/usr/bin/dkms
++ : /usr/bin/dkms
++ INSTALLED=($(get_dkms_versions_installed))
+++ get_dkms_versions_installed
+++ /usr/bin/dkms status
+++ tr -s ':, ' ' '
+++ awk -- '$1 == "hid-xpadneo" { print $2 }'
+++ sort -nu
Deprecated feature: REMAKE_INITRD
Deprecated feature: REMAKE_INITRD
Deprecated feature: REMAKE_INITRD
+ [[ -z '' ]]
+ set -e
+ echo '* creating dkms.conf'
* creating dkms.conf
+ sed 's/"@DO_NOT_CHANGE@"/"v0.9-92-g15319e2"/g'
+ echo '* adding hid-xpadneo-v0.9-92-g15319e2 folder to /usr/src'
* adding hid-xpadneo-v0.9-92-g15319e2 folder to /usr/src
+ mkdir -p /usr/src/hid-xpadneo-v0.9-92-g15319e2
+ cp --recursive --verbose hid-xpadneo/. /usr/src/hid-xpadneo-v0.9-92-g15319e2/.
'hid-xpadneo/./dkms.conf' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././dkms.conf'
'hid-xpadneo/./Makefile' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././Makefile'
'hid-xpadneo/./dkms.conf.in' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././dkms.conf.in'
'hid-xpadneo/./dkms.post_install' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././dkms.post_install'
'hid-xpadneo/./dkms.post_remove' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././dkms.post_remove'
'hid-xpadneo/./etc-udev-rules.d' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././etc-udev-rules.d'
'hid-xpadneo/./etc-udev-rules.d/60-xpadneo.rules' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././etc-udev-rules.d/60-xpadneo.rules'
'hid-xpadneo/./etc-udev-rules.d/50-xpadneo-fixup-steamlink.rules' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././etc-udev-rules.d/50-xpadneo-fixup-steamlink.rules'
'hid-xpadneo/./etc-modprobe.d' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././etc-modprobe.d'
'hid-xpadneo/./etc-modprobe.d/xpadneo.conf' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././etc-modprobe.d/xpadneo.conf'
'hid-xpadneo/./src' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src'
'hid-xpadneo/./src/hid-xpadneo.c' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/hid-xpadneo.c'
'hid-xpadneo/./src/xpadneo.h' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo.h'
'hid-xpadneo/./src/hid-xpadneo.c~' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/hid-xpadneo.c~'
'hid-xpadneo/./src/Makefile' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/Makefile'
'hid-xpadneo/./src/.editorconfig' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/.editorconfig'
'hid-xpadneo/./src/hid-ids.h' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/hid-ids.h'
'hid-xpadneo/./src/xpadneo' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo'
'hid-xpadneo/./src/xpadneo/consumer.c' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo/consumer.c'
'hid-xpadneo/./src/xpadneo/core.c' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo/core.c'
'hid-xpadneo/./src/xpadneo/core.o' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo/core.o'
'hid-xpadneo/./src/xpadneo/.core.o.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo/.core.o.cmd'
'hid-xpadneo/./src/xpadneo/consumer.o' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo/consumer.o'
'hid-xpadneo/./src/xpadneo/.consumer.o.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo/.consumer.o.cmd'
'hid-xpadneo/./src/xpadneo.c' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo.c'
'hid-xpadneo/./src/hid-xpadneo.o' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/hid-xpadneo.o'
'hid-xpadneo/./src/xpadneo.o' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/xpadneo.o'
'hid-xpadneo/./src/.xpadneo.o.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/.xpadneo.o.cmd'
'hid-xpadneo/./src/.hid-xpadneo.o.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/.hid-xpadneo.o.cmd'
'hid-xpadneo/./src/hid-xpadneo.mod' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/hid-xpadneo.mod'
'hid-xpadneo/./src/.hid-xpadneo.mod.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/.hid-xpadneo.mod.cmd'
'hid-xpadneo/./src/modules.order' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/modules.order'
'hid-xpadneo/./src/.modules.order.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/.modules.order.cmd'
'hid-xpadneo/./src/hid-xpadneo.mod.c' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/hid-xpadneo.mod.c'
'hid-xpadneo/./src/Module.symvers' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/Module.symvers'
'hid-xpadneo/./src/.Module.symvers.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/.Module.symvers.cmd'
'hid-xpadneo/./src/hid-xpadneo.mod.o' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/hid-xpadneo.mod.o'
'hid-xpadneo/./src/.hid-xpadneo.mod.o.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/.hid-xpadneo.mod.o.cmd'
'hid-xpadneo/./src/.hid-xpadneo.ko.cmd' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/.hid-xpadneo.ko.cmd'
'hid-xpadneo/./src/hid-xpadneo.ko' -> '/usr/src/hid-xpadneo-v0.9-92-g15319e2/././src/hid-xpadneo.ko'
+ echo '* installing module (using DKMS)'
* installing module (using DKMS)
+ dkms install --verbose hid-xpadneo/v0.9-92-g15319e2 --force
Creating symlink /var/lib/dkms/hid-xpadneo/v0.9-92-g15319e2/source -> /usr/src/hid-xpadneo-v0.9-92-g15319e2

Building module:
make -C /usr/lib/modules/5.15.2-arch1-1/build M=/var/lib/dkms/hid-xpadneo/v0.9-92-g15319e2/build/src clean
make: Entering directory '/usr/lib/modules/5.15.2-arch1-1/build'
  CLEAN   /var/lib/dkms/hid-xpadneo/v0.9-92-g15319e2/build/src/Module.symvers
make: Leaving directory '/usr/lib/modules/5.15.2-arch1-1/build'

{ make -j16 KERNELRELEASE=5.15.2-arch1-1 -C /usr/lib/modules/5.15.2-arch1-1/build M=/var/lib/dkms/hid-xpadneo/v0.9-92-g15319e2/build/src VERSION=v0.9-92-g15319e2 modules; } >> /var/lib/dkms/hid-xpadneo/v0.9-92-g15319e2/build/make.log 2>&1

make -C /usr/lib/modules/5.15.2-arch1-1/build M=/var/lib/dkms/hid-xpadneo/v0.9-92-g15319e2/build/src clean
make: Entering directory '/usr/lib/modules/5.15.2-arch1-1/build'
  CLEAN   /var/lib/dkms/hid-xpadneo/v0.9-92-g15319e2/build/src/Module.symvers
make: Leaving directory '/usr/lib/modules/5.15.2-arch1-1/build'

hid-xpadneo.ko.zst:
Running module version sanity check.
 - Original module
   - Found /usr/lib/modules/5.15.2-arch1-1/kernel/drivers/hid/hid-xpadneo.ko.zst
   - Storing in /var/lib/dkms/hid-xpadneo/original_module/5.15.2-arch1-1/x86_64/
   - Archiving for uninstallation purposes
 - Installation
   - Installing to /usr/lib/modules/5.15.2-arch1-1/kernel/drivers/hid/

Running the post_install script:
Not disabling ERTM, kernel version doesn't require it...
Installing modalias database...
Installing udev rules...
Reloading udev...
do_depmod 5.15.2-arch1-1
codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 860defa1 and detected 0 issues on this pull request.

View more on Code Climate.