search

atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)
https://atar-axis.github.io/xpadneo/
GNU General Public License v3.0
1.92k stars 111 forks source link

Update install.sh #327

Closed jcfrosty closed 2 years ago

jcfrosty commented 2 years ago

New DKMS causing me grief in Manjaro attempting to compile/install module v0.9.1 . Read up on the manual for a quick fix and update here, only to find there was sort of a fix already here. Figured I could help clean it up some.

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit ad45fa87 and detected 0 issues on this pull request.

View more on Code Climate.

kakra commented 2 years ago

There's already a fix in the master branch which also passes the test. Your fix is missing at least one other change. Please wait until I backported the patches, I want to get at least one more fix into 0.9.x for the new Xbox controller models but it looks like that may take a while.

Here's the proposal for v0.9.2: https://github.com/atar-axis/xpadneo/pull/325 - as such closing this PR as a fixed is already existing. You may want to try if it works for you, our CI currently doesn't cover the new DKMS version (which, btw, seems to be buggy, an updated DKMS may also fix your problem).