atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)
https://atar-axis.github.io/xpadneo/
GNU General Public License v3.0
1.87k stars 110 forks source link

Use --depth=1 to reduce download size #412

Closed Apacelus closed 1 year ago

Apacelus commented 1 year ago

Reduces the download size from ~23.4mb to ~3mb

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 5660e236 and detected 0 issues on this pull request.

View more on Code Climate.

kakra commented 1 year ago

I feel like this would cause more harm than benefit. People are encouraged to install via a distribution package. Changing the clone depth would prevent people from properly using branches when asked for in the issues. So I'd argue that people who got that far down are more likely to do development or issue reporting stuff. A size delta of 20 MB is just too small to outperform the possible drawbacks. Yes, it's like 85% less storage but in absolute numbers it's just 20 MB - that's a nothingness in today's systems.

If anything like this should go into the documentation, it should be for the stable branch. Unfortunately, this project doesn't have a linear stable branch, we branch off the current development branch when a development feature is ready and backport patches much like the kernel does. This would mean to change the docs on each stable cycle to the new stable branch name.

I'll leave this open as a reminder to amend the docs to encourage people to use their distribution package or a stable release.