atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)
https://atar-axis.github.io/xpadneo/
GNU General Public License v3.0
1.87k stars 110 forks source link

Disable profile switching to allow key combos #419

Closed alkazar closed 2 months ago

alkazar commented 1 year ago

Version of xpadneo

0.9.5

Controller Model

Connection mode

Describe your feature request

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when ...

Due to emulated profile switching on Xbox One S and Xbox Series controllers, applications such as Steam cannot detect key combos.

For example, Xbox button + A brings up the Quick access menu, Xbox button + X brings up the on screen keyboard in Steam's Gamepad UI. This functionality does not work with xpadneo because of the profile switching functionality which appears to completely swallow the events when I tested with evtest. These key combos do work with the kernel's xpad driver.

Describe the solution you'd like A clear and concise description of what you want to happen.

Since the profile switching feature is unfinished and non-functional, I propose that it be disabled by default and perhaps enabled with a configuration option.

In the xpadneo code, the section starting on line 922 of hid-xpadneo/src/hid-xpadneo.c seems to be related. I suspect disabling that section of code would enable key combos. There does not appear to be an existing configuration option to turn this feature off.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

None

Additional context Add any other context or screenshots about the feature request here.

None