atar-axis / xpadneo

Advanced Linux Driver for Xbox One Wireless Controller (shipped with Xbox One S)
https://atar-axis.github.io/xpadneo/
GNU General Public License v3.0
1.87k stars 110 forks source link

Add configuration for disabling chords #435

Closed BoukeHaarsma23 closed 2 months ago

BoukeHaarsma23 commented 11 months ago

For use with steam, the button chord guide + A is mapped to the QAM. To not lose the profile switching behavior let the user configure this.

closes #419

BoukeHaarsma23 commented 11 months ago

Thanks for the review, I have adjusted everything accordingly.

BoukeHaarsma23 commented 11 months ago

Looks almost good, I'll need to figure out how to fix the CI failing. I may need to merge your PR manually with some amends if you don't mind.

Sure thing! Thanks

codeclimate[bot] commented 11 months ago

Code Climate has analyzed commit 943ae7b1 and detected 0 issues on this pull request.

View more on Code Climate.

kakra commented 4 months ago

@BoukeHaarsma23 I fixed the CI bug, there was a superfluous A in MODULE_PARAM_DESC where it really should be MODULE_PARM_DESC. No idea why my local compiler just accepted it (and yours probably did, too), the CI did not. It's fixed now and queued in my patch queue for testing. This PR will automatically close once I merged it.

anthr76 commented 2 months ago

Will this get merged?

kakra commented 2 months ago

Sorry, I completely forgot about this. I've put it into my local testing branch now to see if there are no side effects.